NOMAD_CLI_NO_COLOR env flag not working

[apollo13]

Nomad version

Nomad v1.1.3 (8c0c814)

Operating system and Environment details

Not relevant.

Issue

While working on #10975 I noticed that NOMAD_CLI_NO_COLOR does not work at all. Supplying -no-color works. main.go takes NOMAD_CLI_NO_COLOR into account

nomad/main.go

Lines 99 to 101 in 6d00c68

	if os.Getenv(command.EnvNomadCLINoColor) != "" {
	color = false
	}

to configure the default UI colors. But nomad plan uses

nomad/command/meta.go

Lines 156 to 162 in 6d00c68

	func (m *Meta) Colorize() *colorstring.Colorize {
	return &colorstring.Colorize{
	Colors: colorstring.DefaultColors,
	Disable: m.noColor || !terminal.IsTerminal(int(os.Stdout.Fd())),
	Reset: true,
	}
	}

which only cares about flags and not env vars. I am not sure what the best way of fixing is. Ie should the env vars override the flags or should they explicitly checked every time etc?

[jrasell]

Thanks for spotting this @apollo13 and taking the time to fill this issue with such detail!

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.