Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remember drain settings on client page #11123

Closed
josegonzalez opened this issue Sep 2, 2021 · 3 comments · Fixed by #11368
Closed

UI: Remember drain settings on client page #11123

josegonzalez opened this issue Sep 2, 2021 · 3 comments · Fixed by #11368
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement

Comments

@josegonzalez
Copy link
Contributor

Proposal

When draining several hosts at once, it would be useful to remember the drain settings between page loads.

Use-cases

We drain certain hosts of everything except system jobs during regular maintenance. We also have a process running that reaps unused hosts, so if we drain the system jobs as well, the server may be accidentally reaped.

Attempted Solutions

A drain button for "drain everything except system" is something hashi-ui has, but in attempting to standardize on Nomad, we'd like to have this functionality there to ease the pain for platform operators.

@lgfa29 lgfa29 added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui labels Sep 3, 2021
@lgfa29 lgfa29 added this to Needs Triage in Nomad - Community Issues Triage via automation Sep 3, 2021
@lgfa29
Copy link
Contributor

lgfa29 commented Sep 3, 2021

Thanks @josegonzalez, just to clarify one thing: would storing the preference in the browser (like we do for ACL token for example) would be enough? Or are you looking for some kind of global configuration?

@josegonzalez
Copy link
Contributor Author

I feel like browser-based storage is fine, and easier to implement. If folks get a new computer, they can re-adjust the settings as necessary.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants