Add FailoverHeartbeatTTL to config #11127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FailoverHeartbeatTTL is the amount of time to wait after a server leader failure before considering reallocating client tasks. This TTL should be fairly long as the new server leader needs to rebuild the entire heartbeat map for the cluster. In deployments with a small number of machines, the default TTL (5m) may be unnecessary long. Let's allow operators to configure this value in their config files.
|
|
|
Bump. Any chance this can be looked at? This would be very useful for my use case. |
… failover_heartbeat_ttl
|
Excellent! Thank you @lgfa29 ! No worries about the delay. I see this is marked for v1.2.0. Any timeframe for that release yet? |
No hard dates yet, but soon 🙂 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FailoverHeartbeatTTL is the amount of time to wait after a server leader failure
before considering reallocating client tasks. This TTL should be fairly long as
the new server leader needs to rebuild the entire heartbeat map for the
cluster. In deployments with a small number of machines, the default TTL (5m)
may be unnecessary long. Let's allow operators to configure this value in their
config files.
In our use case we have a small number of machines (e.g., 7) in the same physical rack, connected with redundant networking (multiple NICs, multiple switches). It is prohibitively expensive for us to dedicate machines to being only nomad servers (which would make FailoverHeartbeatTTL less impactful). In this use case, if heartbeats haven't been responded to within e.g., 30s, the machine is almost definitely failed in some way. No need to wait for 5m.
This relates to #1747 where it was requested that
MinHeartbeatTTLandFailoverHeartbeatTTLwould be made configurable. Since then,MinHeartbeatTTLhas already been made configurable. This PR makesFailoverHeartbeatTTLconfigurable.