Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul Ingress Listener protocols #11169

Closed
sigilion opened this issue Sep 10, 2021 · 2 comments · Fixed by #11187
Closed

Consul Ingress Listener protocols #11169

sigilion opened this issue Sep 10, 2021 · 2 comments · Fixed by #11187
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/enhancement

Comments

@sigilion
Copy link

Proposal

I believe the protocol list here is no longer up to date, according to the consul docs the protocol can also be "grpc" or "http2"

Use-cases

Ingress gateways for grpc and http2 connections

@lgfa29 lgfa29 added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration labels Sep 14, 2021
@lgfa29
Copy link
Contributor

lgfa29 commented Sep 14, 2021

Thanks for the report @sigilion. I've opened a PR to update the list of valid protocols.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants