Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close plaintext connections when disabling rpc_ugprade_mode via SIGHUP reloading #11186

Open
schmichael opened this issue Sep 14, 2021 · 0 comments
Open

Close plaintext connections when disabling rpc_ugprade_mode via SIGHUP reloading #11186

schmichael opened this issue Sep 14, 2021 · 0 comments
Labels
theme/config theme/tls type/bug

Comments

@schmichael
Copy link
Member

Nomad version

Nomad v1.1.3 (8c0c814)

Issue

#11144 allowed disable tls.rpc_upgrade_mode via SIGHUP / hot reloading the Nomad agent. However if disabling upgrade mode (going from true -> false), existing plaintext connections should be disconnected to ensure the change is honored as intended.

Bonus points for fixing the data race around nomad/Server.config when reloading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/config theme/tls type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schmichael