Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a namespace within a CSI volume registration file #11196

Closed
RickyGrassmuck opened this issue Sep 16, 2021 · 3 comments · Fixed by #12400
Closed

Allow specifying a namespace within a CSI volume registration file #11196

RickyGrassmuck opened this issue Sep 16, 2021 · 3 comments · Fixed by #12400
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/enhancement
Milestone

Comments

@RickyGrassmuck
Copy link
Contributor

RickyGrassmuck commented Sep 16, 2021

Proposal

Currently, the only way to specify a CSI Volume's namespace is by adding the -namespace= flag in the nomad volume create command.

Allowing to specify the namespace within the volume spec file would make the creation of a new CSI volume consistent with submitting a Nomad job as well as prevent accidentally registering a volume in a namespace that differs from the namespace of the job the volume is intended to be used with.

Example:

type            = "csi"
id              = "metrics_prometheus"
name            = "metrics_prometheus"
namespace       = "thunderdome"
access_mode     = "single-node-writer"
attachment_mode = "file-system"
plugin_id       = "cinder-csi"

capacity_max = "5G"
capacity_min = "5G"

capability {  
  access_mode     = "single-node-writer"  
  attachment_mode = "file-system"
}

mount_options {
  fs_type = "ext4"
}

Use-cases

Allowing the volume specification to be more declarative and consistent with the jobspecs they are accompanying.

Attempted Solutions

N/A

@DerekStrickland
Copy link
Contributor

Hi @rigrassm,

Thanks for using Nomad!

I'm currently taking a look into what it will take to implement this. We'll update this issue as more details emerge.

Thanks,

Derek and the Nomad Team

@DerekStrickland DerekStrickland moved this from Triaging to In Progress in Nomad - Community Issues Triage Sep 24, 2021
@DerekStrickland DerekStrickland moved this from In Progress to Needs Roadmapping in Nomad - Community Issues Triage Oct 27, 2021
@DerekStrickland DerekStrickland removed their assignment Oct 27, 2021
@tgross tgross added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Nov 18, 2021
@tgross tgross self-assigned this Mar 29, 2022
@tgross tgross moved this from Needs Roadmapping to In Progress in Nomad - Community Issues Triage Mar 29, 2022
@tgross
Copy link
Member

tgross commented Mar 29, 2022

Will be fixed in #12400, planned to ship in Nomad 1.3.0. As it turns out, most required plumbing was already done, we just needed to fix one case where it was getting overridden in the RPC handler and the rest was testing and docs.

@tgross tgross added this to the 1.3.0 milestone Mar 29, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Mar 29, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/enhancement
Projects
Development

Successfully merging a pull request may close this issue.

3 participants