Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -show-url option for ui command #11213

Merged
merged 3 commits into from
Oct 6, 2021
Merged

add -show-url option for ui command #11213

merged 3 commits into from
Oct 6, 2021

Conversation

yaroot
Copy link
Contributor

@yaroot yaroot commented Sep 21, 2021

closes #11193

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @yaroot!

From my test, there's a duplicate message with the URL when the new flag is passed. I have a suggestion on how we can avoid it, but feel free to implement it another way if you find a better solution 🙂

command/ui.go Outdated Show resolved Hide resolved
website/content/docs/commands/ui.mdx Outdated Show resolved Hide resolved
command/ui.go Show resolved Hide resolved
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @yaroot, things are working as expected now 🙂

I pushed a couple of commits to enhance the documentation and also to add a CHANGELOG entry.

Thank you for the contribution!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to show url with nomad ui -authenticate
3 participants