fix panic when Connect mesh gateway doesn't have a proxy block #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
reviewed
Oct 4, 2021
schmichael
approved these changes
Oct 4, 2021
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Oct 4, 2021
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
gateway -> meshblock is set in a service without aproxyblock, Nomad is expected to generate a default proxy configuration. This was being done when the group network mode wasbridge, but not when it washost, even though that is a supported option.Without the proxy configuration, Nomad would panic when trying to generate the Consul API request to register the service.
This PR generates the proxy configuration regardless of the network mode. When in
bridge, the previous behaviour is preserved. Inhost, no special configuration is done, so the default Consul behaviour is used.Closes #11243