Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Improved autocomplete support for job dispatch and operator debug #11270

Merged
merged 8 commits into from
Oct 13, 2021
Merged

cli: Improved autocomplete support for job dispatch and operator debug #11270

merged 8 commits into from
Oct 13, 2021

Conversation

davemay99
Copy link
Contributor

This PR provides additional autocomplete support for the following commands:

nomad operator debug

  • -log-level
  • -node-class
  • -node-id
  • -server-id
  • -output

nomad job dispatch

  • only autocomplete parameterized jobs

@vercel vercel bot temporarily deployed to Preview – nomad October 6, 2021 03:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 6, 2021 13:44 Inactive
@davemay99 davemay99 changed the title F-debug-autocomplete cli: autocomplete improvements for dispatch/debug Oct 6, 2021
@davemay99 davemay99 changed the title cli: autocomplete improvements for dispatch/debug cli: Improved autocomplete support for job dispatch and operator debug Oct 6, 2021
DerekStrickland
DerekStrickland reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions before I hit the approve button.

command/operator_debug.go Outdated Show resolved Hide resolved
command/job_dispatch.go Outdated Show resolved Hide resolved
command/operator_debug.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 22:04 Inactive
@davemay99
Copy link
Contributor Author

@DerekStrickland I addressed the issues you raised, and rebased to align with changes recently merged into main. Should be good to go, but please let me know if there are any remaining concerns.

DerekStrickland
DerekStrickland approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making those consistent.

@davemay99 davemay99 merged commit 6852f21 into main Oct 13, 2021
@davemay99 davemay99 deleted the f-debug-autocomplete branch October 13, 2021 00:01
@davemay99 davemay99 added this to the 1.2.0 milestone Oct 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DerekStrickland DerekStrickland DerekStrickland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davemay99 @DerekStrickland