Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a -hcl2-strict flag to allow for lenient hcl variable parsing. #11284

Merged
merged 5 commits into from
Nov 4, 2021

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Oct 7, 2021

@jrasell Hi I have added a -lenient flag to allow users to enable non-strict parsing of the job variables. What do you think?

closes #11164

@vercel vercel bot temporarily deployed to Preview – nomad November 4, 2021 07:36 Inactive
@jrasell jrasell requested a review from lgfa29 November 4, 2021 07:37
@jrasell jrasell added this to the 1.2.0 milestone Nov 4, 2021
@jrasell jrasell changed the title Added a -lenient flag to allow for lenient hcl variable parsing. Added a -hcl2-strict flag to allow for lenient hcl variable parsing. Nov 4, 2021
@jrasell
Copy link
Member

jrasell commented Nov 4, 2021

Hi @apollo13; thanks for this and sorry it took so long to get around to it. Internally we discussed the flag name and opted for hcl2-strict as lenient felt a little vague and this keeps consistent with the hcl1 flag naming style already in place. I have pushed some changes which modify the flag name, fixed the test failures, and update the documentation. As I have now pushed to this PR I cannot approve and merge, therefore have tagged @lgfa29 for this.

@apollo13
Copy link
Contributor Author

apollo13 commented Nov 4, 2021

Thanks for getting to this @jrasell -- much appreciated. I am fine with the new naming I just didn't want to solely complain, that is why I added code in the first place :) The new patch looks great and I will try it later today.

@apollo13
Copy link
Contributor Author

apollo13 commented Nov 4, 2021

Patch works great!

@lgfa29 lgfa29 changed the base branch from b-gh-11149 to main November 4, 2021 14:11
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jobspec: expose the hcl2 strict config parameter for user toggling
3 participants