prevent active log from being overwritten when agent starts #11386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
fix-append-to-active-log
branch
from
66fb845
to
fd16ea1
Compare
schmichael
approved these changes
Oct 27, 2021
lgfa29
added a commit
that referenced
this pull request
Nov 15, 2021
lgfa29
added a commit
that referenced
this pull request
Nov 15, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #11070 the agent assumed that a new log file always started fresh, and so it truncated the file and assumed it was just created.
#11070 changed this behaviour to keep the active log file name stable, but didn't modify the full process. This caused the agent to overwrite log lines that were not rotated in a previous run.
This PR updates the logic so new log lines are appended to the active log file and that the internal state is also updated accordingly with the existing file information.
Closes #11379