Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse job > group > consul block in HCL1 #11423

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Parse job > group > consul block in HCL1 #11423

merged 3 commits into from
Nov 3, 2021

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Nov 1, 2021

Moved the validate function into structs/consul_oss.go so that we can have alternative enterprise implementation. Prevents silent ignore.
Added parse test for jobspec and error tests on the struct

Closes #11422

@angrycub
Parse job > group > consul block in HCL1
3ff5201 
Moved the validate function into structs/consul_oss.go so that we can have alternative enterprise implementation. Prevents silent ignore.
Added parse test for jobspec and error tests on the struct
@angrycub angrycub added this to the 1.2.0 milestone Nov 1, 2021
@angrycub angrycub requested a review from lgfa29 November 1, 2021 23:11
@angrycub angrycub self-assigned this Nov 1, 2021
@vercel vercel bot temporarily deployed to Preview – nomad November 3, 2021 17:14 Inactive
lgfa29
lgfa29 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As discussed, I reverted the validation error since this field depends on Consul Enterprise. I will turn it into a constraint in a follow-up PR to match the behaviour of other Consul related fields, such as connect.

@vercel vercel bot temporarily deployed to Preview – nomad November 3, 2021 17:19 Inactive
@lgfa29 lgfa29 merged commit 6efa55e into main Nov 3, 2021
@lgfa29 lgfa29 deleted the b-validate-consul-namespace branch November 3, 2021 17:49
lgfa29 pushed a commit that referenced this pull request Nov 15, 2021
@angrycub @lgfa29
Parse job > group > consul block in HCL1 (#11423)
b9b8fa9
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees

@angrycub angrycub

Labels
theme/consul type/enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

consul block inside group is silently ignored on Nomad OSS
2 participants
@angrycub @lgfa29