-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide -no-shutdown-delay flag on job/alloc stop to bypass kill timeout #11448
Comments
Some interesting bits to figure out here:
My initial thought here for implementation was to update the job so that the I think the approach here will be to add a new (Also, we might want to name this flag |
Getting close to the end of my day here so leaving notes for myself: I've got an almost-working branch of The group service hook waiting on the Currently alloc runner hooks don't get their Edit: a much easier approach will be to expose the allocation update to the alloc runner hook |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Some operators use long kill timeouts so that tasks have a long window of time to shutdown cleanly. During incident response, these long kill timeouts can make it hard to mitigate the incident. Provide an
-immediate
flag onnomad job stop
andnomad alloc stop
that bypasses the kill timeout. We'll still run allocrunner/taskrunner prestop hooks (because the client state needs that). Maybe an open question would be what should we do with tasks with thepoststop
lifecycle configuration?The text was updated successfully, but these errors were encountered: