Refactor fs subcommands into fs command #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `nomad fs` command to eliminate `fs` subcommands. Automatically displays the file, if the path specified is a file; lists the directory if the path is a directory; or displays stat information if the `-stat` flag is set. Currently running `nomad fs ls` to find a file, then running the exact same command with the exception of `cat` instead of `ls` is time consuming and awkward. This allows operational testing to be greatly enhanced, and makes our lives so much better.
|
@grubernaut Can you also please update the docs for this change? |
|
@diptanu done! |
| ) | ||
|
|
||
| type FSCommand struct { | ||
| Meta | ||
| } | ||
|
|
||
| func (f *FSCommand) Help() string { | ||
| return "This command is accessed by using one of the subcommands below." | ||
| helpText := ` | ||
| Usage: nomad fs <alloc-id> <path> |
There was a problem hiding this comment.
Fix indents to be in-line with the rest of the commands
|
LGTM |
|
@dadgar PTAL |
cgbaker
pushed a commit
that referenced
this pull request
Nov 26, 2018
use this for volume names in drivers/rkt to address #1150
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
nomad fscommand to eliminatefssubcommands.Automatically displays the file, if the path specified is a file; lists
the directory if the path is a directory; or displays stat information
if the
-statflag is set.Currently running
nomad fs lsto find a file, then running the exactsame command with the exception of
catinstead oflsis timeconsuming and awkward. This allows operational testing to be greatly
enhanced, and makes our lives so much better.