metrics: added mapped_file metric
#11500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `mapped_file` in DockerStatsToTaskResourceUsage - added `mapped_file` in LibcontainerExecutor.handleStats Fixes hashicorp#10067 Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
servusdei2018
approved these changes
Nov 25, 2021
Co-authored-by: Nate <37554478+servusdei2018@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #10067 and trivially adds
mapped_filein DockerStatsToTaskResourceUsage.It sounds like that the
mapped_filemetric is needed in here as well:https://github.com/deblasis/nomad/blob/b4a230d2cf57ff7a18c1e3bca006a9a7c4b284ca/drivers/shared/executor/executor_linux.go#L386
I had a look at runc code and it seems that the metric is pulled from the
memory.statfile, in compliance with https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txtso I thought it was a good thing to add it in
LibcontainerExecutoras well.If you think it's a welcome addition and tests are needed, I would like a pointer on how to test that as well.
Cheers