Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add consul and vault links to global header #11557

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

ChaiWithJai
Copy link
Contributor

No description provided.

@github-actions
Copy link

Ember Asset Size action

As of ae8320c

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +579 B +75 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main ae8320c change
passes 1195 1199 +4
failures 1 0 -1
flaky 4 0 -4
duration 000ms 9m 37s 708ms +9m 37s 708ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@ChaiWithJai ChaiWithJai linked an issue Nov 24, 2021 that may be closed by this pull request
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChaiWithJai ChaiWithJai merged commit e349316 into main Nov 24, 2021
@ChaiWithJai ChaiWithJai deleted the f-ui/consul-vault-link branch November 24, 2021 19:02
lgfa29 added a commit that referenced this pull request Dec 18, 2021
lgfa29 added a commit that referenced this pull request Dec 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] consul & vault hyperlinks
2 participants