Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Consul template configuration parameters #11606

Merged
merged 16 commits into from
Jan 10, 2022
Merged

Expose Consul template configuration parameters #11606

merged 16 commits into from
Jan 10, 2022

Conversation

DerekStrickland
Copy link
Contributor

@DerekStrickland DerekStrickland commented Dec 2, 2021 •
edited
Loading

See #11707 for a full explanation.

Expose Consul template configuration parameters for operators to tune at multiple levels:

  • jobspec
    • wait - will override client default on a per template basis if set, or add if no client default set
  • client
    • wait
    • wait_bounds - if set, will enforce upper and lower bounds on per template wait configured by jobspec authors
    • block_query_wait
    • max_stale - default to 5s
    • consul_retry
    • vault_retry

Closes #11707
Closes #3866
Closes #2623
Closes #11209

@DerekStrickland DerekStrickland self-assigned this Dec 2, 2021
@vercel vercel bot temporarily deployed to Preview – nomad December 2, 2021 20:00 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 6, 2021 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 8, 2021 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 9, 2021 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 9, 2021 15:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 9, 2021 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 10, 2021 19:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 11, 2021 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 13, 2021 09:51 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 16, 2021 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 16, 2021 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad January 5, 2022 23:19 Inactive
schmichael
schmichael reviewed Jan 6, 2022
View reviewed changes
.changelog/11606.txt Outdated Show resolved Hide resolved
website/content/docs/configuration/client.mdx Outdated Show resolved Hide resolved
@DerekStrickland @schmichael
Update .changelog/11606.txt
0144246 
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – nomad January 7, 2022 08:59 Inactive
@DerekStrickland
Copy link
Contributor Author

@tgross / @schmichael - I believe this is ready for (hopefully!) final review.

tgross
tgross approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left some final comments on documentation wording but once those are fixed I'm 👍 with merging this.

client/allocrunner/taskrunner/template/template_test.go Show resolved Hide resolved
website/content/docs/job-specification/template.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/client.mdx Outdated Show resolved Hide resolved
@DerekStrickland DerekStrickland merged commit 43edd0e into main Jan 10, 2022
@DerekStrickland DerekStrickland deleted the f-expose-consul-template-config branch January 10, 2022 15:19
@tgross tgross mentioned this pull request Jan 10, 2022
Closed
@jrasell jrasell mentioned this pull request Jan 24, 2022
Closed
@ngmlabs ngmlabs mentioned this pull request Jan 25, 2022
Closed
@mikenomitch mikenomitch mentioned this pull request Feb 22, 2022
Closed
@tgross tgross mentioned this pull request Apr 15, 2022
Closed
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael left review comments

@tgross tgross tgross approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@DerekStrickland DerekStrickland

Labels
theme/consul-template type/enhancement
Projects
None yet
Milestone
No milestone
3 participants
@DerekStrickland @schmichael @tgross