Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command nomad plan output doesn't contain variables parameters #11616

Closed
Liraim opened this issue Dec 5, 2021 · 3 comments
Closed

Command nomad plan output doesn't contain variables parameters #11616

Liraim opened this issue Dec 5, 2021 · 3 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli theme/plan type/bug
Milestone

Comments

@Liraim
Copy link
Contributor

Liraim commented Dec 5, 2021

Nomad version

Output from nomad version

Nomad v1.2.2

Operating system and Environment details

Tested on MacOS and Windows.

Issue

Running nomad plan ... command with -var or -varfile arguments doesn't contains this arguments in output (in To submit the job with version verification run: part).

Reproduction steps

Run valid nomad plan with -var or -varfile arguments and see output.

Expected Result

nomad plan output contains full nomad run command which can be copied and executed without additional actions.

Actual Result

nomad plan output contains only partial output so before executing it, you need to manually add missing arguments.

Job file (if appropriate)

Nomad Server logs (if appropriate)

Nomad Client logs (if appropriate)

@Liraim Liraim added the type/bug label Dec 5, 2021
@jrasell jrasell added theme/cli theme/plan stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Dec 6, 2021
@jrasell
Copy link
Member

jrasell commented Dec 6, 2021

Hi @Liraim and thanks for raising this. The change makes a lot of sense and is something we should certainly include.

@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation Dec 6, 2021
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Dec 6, 2021
@tgross tgross added this to the 1.2.3 milestone Dec 7, 2021
@tgross tgross moved this from Needs Roadmapping to In Progress in Nomad - Community Issues Triage Dec 7, 2021
@tgross
Copy link
Member

tgross commented Dec 8, 2021

Closed by #11631 and will ship in the next release.

@tgross tgross closed this as completed Dec 8, 2021
Nomad - Community Issues Triage automation moved this from In Progress to Done Dec 8, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli theme/plan type/bug
Projects
Development

No branches or pull requests

3 participants