cli: ensure -stale flag is respected by nomad operator debug
#11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
operator-debug-stale
branch
from
efec2e4
to
77dd8ed
Compare
tgross
force-pushed
the
operator-debug-stale
branch
from
77dd8ed
to
350949d
Compare
tgross
commented
Dec 14, 2021
| @@ -48,6 +47,7 @@ type OperatorDebugCommand struct { | |||
| manifest []string | |||
| ctx context.Context | |||
| cancel context.CancelFunc | |||
| opts *api.QueryOptions | |||
There was a problem hiding this comment.
Note for reviewers: I'm not wild about having it stuck in the OperatorDebugCommand like this, but the command keeps around a lot of state here and untangling all that was more of a refactor than I wanted to do in this PR. I can come back and do some refactoring later.
There was a problem hiding this comment.
I think this looks OK. Something would need to be passed around regardless, and yeah, there's a lot going on in this command 😄
tgross
force-pushed
the
operator-debug-stale
branch
from
350949d
to
667e926
Compare
lgfa29
approved these changes
Dec 14, 2021
| @@ -48,6 +47,7 @@ type OperatorDebugCommand struct { | |||
| manifest []string | |||
| ctx context.Context | |||
| cancel context.CancelFunc | |||
| opts *api.QueryOptions | |||
There was a problem hiding this comment.
I think this looks OK. Something would need to be passed around regardless, and yeah, there's a lot going on in this command 😄
When a cluster doesn't have a leader, the `nomad operator debug` command can safely use stale queries to gracefully degrade the consistency of almost all its queries. The query parameter for these API calls was not being set by the command. Some `api` package queries do not include `QueryOptions` because they target a specific agent, but they can potentially be forwarded to other agents. If there is no leader, these forwarded queries will fail. Provide methods to call these APIs with `QueryOptions`.
tgross
force-pushed
the
operator-debug-stale
branch
from
667e926
to
9f18222
Compare
lgfa29
pushed a commit
that referenced
this pull request
Jan 17, 2022
) When a cluster doesn't have a leader, the `nomad operator debug` command can safely use stale queries to gracefully degrade the consistency of almost all its queries. The query parameter for these API calls was not being set by the command. Some `api` package queries do not include `QueryOptions` because they target a specific agent, but they can potentially be forwarded to other agents. If there is no leader, these forwarded queries will fail. Provide methods to call these APIs with `QueryOptions`.
lgfa29
pushed a commit
that referenced
this pull request
Jan 17, 2022
) When a cluster doesn't have a leader, the `nomad operator debug` command can safely use stale queries to gracefully degrade the consistency of almost all its queries. The query parameter for these API calls was not being set by the command. Some `api` package queries do not include `QueryOptions` because they target a specific agent, but they can potentially be forwarded to other agents. If there is no leader, these forwarded queries will fail. Provide methods to call these APIs with `QueryOptions`.
lgfa29
pushed a commit
that referenced
this pull request
Jan 17, 2022
) When a cluster doesn't have a leader, the `nomad operator debug` command can safely use stale queries to gracefully degrade the consistency of almost all its queries. The query parameter for these API calls was not being set by the command. Some `api` package queries do not include `QueryOptions` because they target a specific agent, but they can potentially be forwarded to other agents. If there is no leader, these forwarded queries will fail. Provide methods to call these APIs with `QueryOptions`.
lgfa29
pushed a commit
that referenced
this pull request
Jan 18, 2022
) When a cluster doesn't have a leader, the `nomad operator debug` command can safely use stale queries to gracefully degrade the consistency of almost all its queries. The query parameter for these API calls was not being set by the command. Some `api` package queries do not include `QueryOptions` because they target a specific agent, but they can potentially be forwarded to other agents. If there is no leader, these forwarded queries will fail. Provide methods to call these APIs with `QueryOptions`.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10767
When a cluster doesn't have a leader, the
nomad operator debugcommand can safely use stale queries to gracefully degrade the
consistency of almost all its queries. The query parameter for these
API calls was not being set by the command.
Some
apipackage queries do not includeQueryOptionsbecausethey target a specific agent, but they can potentially be forwarded to
other agents. If there is no leader, these forwarded queries will
fail. Provide methods to call these APIs with
QueryOptions.