Job.Plan endpoint #1168
Merged
Job.Plan endpoint #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reply.Diff = jobDiff | ||
| } | ||
|
|
||
| reply.Cas = index |
There was a problem hiding this comment.
I would just call it the JobModifyIndex instead of CAS since that is much clearer
|
LGTM! |
| } | ||
|
|
||
| // Validate the driver configurations. | ||
| for _, tg := range job.TaskGroups { |
There was a problem hiding this comment.
Can't this logic move into job.Validate as well?
There was a problem hiding this comment.
Not quite, it creates a circular dependency
|
LGTM |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Plan endpoint and adds: