Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix host network reserved port fingerprint #11728

Merged
merged 3 commits into from
Dec 22, 2021
Merged

fix host network reserved port fingerprint #11728

merged 3 commits into from
Dec 22, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 22, 2021 •
edited
Loading

During the network fingerprint, client configuration values are mapped to actual network addresses and interfaces. During this process a ClientHostNetworkConfig is translated into NodeNetworkResource, but reserved ports were not being set.

Closes #9492

@vercel vercel bot temporarily deployed to Preview – nomad December 22, 2021 01:52 Inactive
tgross
tgross approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/fingerprint/network_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad December 22, 2021 16:08 Inactive
@lgfa29 lgfa29 merged commit 5e112a8 into main Dec 22, 2021
@lgfa29 lgfa29 deleted the b-fix-host-network-fingerprint branch December 22, 2021 20:29
@lgfa29 lgfa29 added this to the 1.2.4 milestone Dec 23, 2021
lgfa29 added a commit that referenced this pull request Jan 17, 2022
@lgfa29
fix host network reserved port fingerprint (#11728)
8097b5e
lgfa29 added a commit that referenced this pull request Jan 17, 2022
@lgfa29
fix host network reserved port fingerprint (#11728)
bbbd6ec
lgfa29 added a commit that referenced this pull request Jan 17, 2022
@lgfa29
fix host network reserved port fingerprint (#11728)
6bd26da
lgfa29 added a commit that referenced this pull request Jan 17, 2022
@lgfa29
fix host network reserved port fingerprint (#11728)
4c5ff51
lgfa29 added a commit that referenced this pull request Jan 18, 2022
@lgfa29
fix host network reserved port fingerprint (#11728)
f730bc2
@jrasell jrasell mentioned this pull request Jan 24, 2022
Closed
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

Reserved ports are not honored
3 participants
@lgfa29 @schmichael @tgross