Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from BoltDB to bbolt #11775

Closed
schmichael opened this issue Jan 4, 2022 · 3 comments · Fixed by #12107
Closed

Upgrade from BoltDB to bbolt #11775

schmichael opened this issue Jan 4, 2022 · 3 comments · Fixed by #12107

Comments

@schmichael
Copy link
Member

Proposal

Follow Consul's lead of switching from the original unmaintained bolt code base to the maintained fork: hashicorp/consul#11720

Both the server's Raft state store and the client's local state database should be migrated.

Use-cases

The original bolt code base has proven to be extremely robust for Nomad. However there are known bugs and no reason to believe Nomad users won't someday hit them.

The main reason for switching is consistency between HashiCorp products. We can benefit from the excellent research the Vault and Consul team's have done into things like the new bolt fork's freelist syncing options.

@mikenomitch mikenomitch changed the title https://github.com/hashicorp/consul/issues/8442 Upgrade from BoltDB to bbolt Jan 4, 2022
@mikenomitch
Copy link
Contributor

As part of this issue we should include a couple things beyond just the code change:

@chuckyz
Copy link
Contributor

chuckyz commented Feb 10, 2022

I'll throw out to mike/michael, that in my personal testing downgrading from bolt to bbolt (with Consul) is straight up impossible, I don't think there is actually any downgrade path. That said, doing this one server at a time and rolling back to a binary with bolt instead of bbolt and re-populating the raftdb works perfectly, and running mixed bolt/bbolt workloads intra-cluster is totally fine as it's just a storage engine on any given box and doesn't seem to affect the cluster at all.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants