Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: updates on register/create aren't allowed #11786

Closed
tgross opened this issue Jan 6, 2022 · 2 comments · Fixed by #12167
Closed

CSI: updates on register/create aren't allowed #11786

tgross opened this issue Jan 6, 2022 · 2 comments · Fixed by #12167

Comments

@tgross
Copy link
Member

tgross commented Jan 6, 2022

While working on #10927 and #10833 and I noticed that csi_hook.go doesn't implement interfaces.RunnerUpdateHook, so there's no way to update CSI volume in place on an allocation, but the validateJobUpdate doesn't know that and will merrily let you update it without warning you.

Implement the RunnerUpdateHook interface as well.

@tgross
Copy link
Member Author

tgross commented Feb 25, 2022

After having spent some time in the register/create workflow to do #12129 I'm realizing that we generally can't implement CSI hooks non-destructively, because all the client-side behaviors would require remounting the volume. So there's no need for an update hook in csi_hook.go.

But we do need to make sure the semantics of updating a volume with nomad volume register and nomad volume create are correct and legible. I'm going to update the title of this issue for that instead.

@tgross tgross changed the title CSI: allocrunner hook doesn't implement Update hook CSI: updates on register/create aren't validated Feb 25, 2022
@tgross tgross changed the title CSI: updates on register/create aren't validated CSI: updates on register/create aren't allowed Mar 3, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant