You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #10927 and #10833 and I noticed that csi_hook.go doesn't implement interfaces.RunnerUpdateHook, so there's no way to update CSI volume in place on an allocation, but the validateJobUpdate doesn't know that and will merrily let you update it without warning you.
Implement the RunnerUpdateHook interface as well.
The text was updated successfully, but these errors were encountered:
After having spent some time in the register/create workflow to do #12129 I'm realizing that we generally can't implement CSI hooks non-destructively, because all the client-side behaviors would require remounting the volume. So there's no need for an update hook in csi_hook.go.
But we do need to make sure the semantics of updating a volume with nomad volume register and nomad volume create are correct and legible. I'm going to update the title of this issue for that instead.
tgross
changed the title
CSI: allocrunner hook doesn't implement Update hook
CSI: updates on register/create aren't validated
Feb 25, 2022
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
While working on #10927 and #10833 and I noticed that
csi_hook.go
doesn't implementinterfaces.RunnerUpdateHook
, so there's no way to update CSI volume in place on an allocation, but thevalidateJobUpdate
doesn't know that and will merrily let you update it without warning you.Implement the
RunnerUpdateHook
interface as well.The text was updated successfully, but these errors were encountered: