Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: validate reserved_ports are valid #11830

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Conversation

schmichael
Copy link
Member

Minimal alternative to #11819. I think the more drastic changes in the other PR should wait until 1.3.

Goal is to fix at least one of the causes that can cause a node to be
ineligible to receive work:
#9506 (comment)

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Minor comments on output values, but not blockers 👍

command/agent/command.go Outdated Show resolved Hide resolved
nomad/structs/funcs.go Outdated Show resolved Hide resolved
Goal is to fix at least one of the causes that can cause a node to be
ineligible to receive work:
#9506 (comment)
@vercel vercel bot temporarily deployed to Preview – nomad January 12, 2022 22:21 Inactive
@schmichael schmichael merged commit 07fd6d9 into main Jan 13, 2022
@schmichael schmichael deleted the b-validate-reserved-ports branch January 13, 2022 01:12
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
lgfa29 pushed a commit that referenced this pull request Jan 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants