Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Allocation Metrics stored in Evaluation #1188

Merged
merged 6 commits into from
May 25, 2016
Merged

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented May 19, 2016

This PR:

  • The scheduler no longer creates a failed allocation per task group that failed to place
  • Stores the failure metrics for debugging inside the Evaluation
  • Updates the eval-monitor to print the task group failure metrics
  • Adds a SpawnedBlockedEval field to the Evaluation so you can see that a blocked eval was created

A follow up PR will introduce a eval-status command that prints this information and will deprecate eval-monitor and introduce eval-status -monitor.

Sample output of the monitor with failures:

    Evaluation status changed: "pending" -> "complete"
==> Evaluation "d81bd79f" finished with status "complete" but failed to place all allocations:
    Task Group "api" (failed to place 6 allocations):
      * Resources exhausted on 1 nodes
      * Dimension "cpu exhausted" exhausted on 1 nodes
    Task Group "cache" (failed to place 5 allocations):
      * Resources exhausted on 1 nodes
      * Dimension "cpu exhausted" exhausted on 1 nodes
    Spawned follow up blocked evaluation "34ac2671" to place remainder

Wait time.Duration
NextEval string
PreviousEval string
SpawnedBlockedEval string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to BlockedEval

@armon
Copy link
Member

armon commented May 25, 2016

LGTM

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants