Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: volume status detail output has incorrect -verbose handling #11964

Closed
tgross opened this issue Jan 31, 2022 · 1 comment · Fixed by #12153
Closed

CSI: volume status detail output has incorrect -verbose handling #11964

tgross opened this issue Jan 31, 2022 · 1 comment · Fixed by #12153

Comments

@tgross
Copy link
Member

tgross commented Jan 31, 2022

In #10164 (shipped in Nomad 1.2.5) we fixed the output of nomad volume status so that the IDs of volumes were not truncated. They're not UUIDs, so that made sense. But the fix also impacted the detailed output we get from nomad volume status :volume_id such that the allocation and node IDs for each allocation are listed at their full length as well. For example:

$ nomad volume status csi-volume-nfs0
ID                   = csi-volume-nfs0
Name                 = csi-volume-nfs0
External ID          = csi-volume-nfs0
Plugin ID            = org.democratic-csi.nfs
Provider             = org.democratic-csi.nfs
Version              = 1.4.3
Schedulable          = true
Controllers Healthy  = 2
Controllers Expected = 2
Nodes Healthy        = 3
Nodes Expected       = 3
Access Mode          = multi-node-multi-writer
Attachment Mode      = file-system
Mount Options        = <none>
Namespace            = default

Allocations
ID                                    Node ID                               Task Group  Version  Desired  Status   Created    Modified
ee02cd08-5978-b77f-0a4b-e145c4b639f2  9b18730c-dc1b-ff91-4040-a1432549f466  web         1        run      running  3m27s ago  3m11s ago
4703cb94-f073-9894-2e25-e2ad9360be5f  ae03e9fe-14c7-48f4-eeac-5a325dba8ad5  web         1        run      running  2m33s ago  2m22s ago

We should use the full ID for only the volume ID/name, and then respect the -verbose flag for the allocation and node IDs as we do everywhere else.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant