-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse blocked evaluations and handle unblock events that occurred during scheduling #1199
Conversation
84fb757
to
c7b7a9b
Compare
…an update while in the scheduler
c7b7a9b
to
8456f77
Compare
@@ -133,6 +146,14 @@ func (b *BlockedEvals) Block(eval *structs.Evaluation) { | |||
return | |||
} | |||
|
|||
// Check if the eval missed an unblock while it was in the scheduler at an | |||
// older index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add some more comment as to how/why this is possible. "The scheduler could have been invoked with a snapshot of state that was prior to additional capacity being added or allocations becoming terminal."
LGTM |
fb804d7
to
230b663
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR:
@armon for review. Should be reviewed after #1188 is merged and this rebased.