Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot deregister volume while its id is a prefix of other volume id. #12005

Closed
kriestof opened this issue Feb 4, 2022 · 3 comments · Fixed by #12051
Closed

Cannot deregister volume while its id is a prefix of other volume id. #12005

kriestof opened this issue Feb 4, 2022 · 3 comments · Fixed by #12051
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/bug
Milestone

Comments

@kriestof
Copy link

kriestof commented Feb 4, 2022

Nomad version

1.2.5

Operating system and Environment details

Arch linux

Issue

I try to deregister volume which id is a prefix of other volume. But then I got an error

nomad volume deregister registry-volume
Prefix matched multiple volumes

ID                Name             Plugin ID  Schedulable  Access Mode
registry-volume   Docker registry  ceph-csi   true         multi-node-multi-writer
registry-volume1  Docker registry  ceph-csi   true         multi-node-multi-writer

It's non-critical and definitely a corner case as I can deregister registry-volume1 and then registry-volume.

Reproduction steps

Register 2 volumes registry-volume and registry-volume1. Then try to deregister registry-volume.

Expected Result

Volume matched by exact id should be deregistered.

Actual Result

There is an error that multiple prefixes was matched.

@tgross
Copy link
Member

tgross commented Feb 4, 2022

Hi @kriestof! We fixed a bug in the deregister prefix matching in #11852 which shipped in Nomad 1.2.4, where prefixes were used to deregister. But you're right, we should also have followed that up with changes to the CLI to account for exact matches, similarly to how we do for job ID.

I'm in the middle of a big set of work on CSI, so I'll make sure this gets added to that pile. Thanks!

@tgross tgross added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage labels Feb 4, 2022
@tgross tgross added this to the 1.3.0 milestone Feb 10, 2022
@tgross
Copy link
Member

tgross commented Feb 10, 2022

Fixed in #12051 which should ship in Nomad 1.3.0

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants