Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolate network.dns block on client (fixes #11851) #12021

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

nvx
Copy link
Contributor

@nvx nvx commented Feb 8, 2022

This implements client side interpolation of the network.dns block to fix #11851.

Unit tests, changelog entry, and website docs have been added/updated.

@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2022 02:54 Inactive
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Feb 8, 2022
@tgross tgross self-requested a review February 9, 2022 19:27
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Feb 9, 2022
@tgross tgross self-assigned this Feb 9, 2022
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nvx!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

interpolate network.dns block on client
2 participants