Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: merge ReservableCores in clientConfig #12044

Merged
merged 1 commit into from
Feb 15, 2022
Merged

bug: merge ReservableCores in clientConfig #12044

merged 1 commit into from
Feb 15, 2022

Conversation

aholyoake-bc
Copy link
Contributor

@aholyoake-bc aholyoake-bc commented Feb 10, 2022 •
edited
Loading

Fixes: #12043

Note: There is an inconsistency throughout the codebase regarding Reserveable and Reservable

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Feb 10, 2022
@tgross tgross self-requested a review February 11, 2022 15:35
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Feb 11, 2022
@tgross tgross self-assigned this Feb 11, 2022
tgross
tgross approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross
Copy link
Member

tgross commented Feb 15, 2022

Thanks @aholyoake-bc! For some reason CircleCI isn't running on this PR, but LGTM. I'll keep an eye on CI once it gets merged and add a commit for the changelog.

tgross
tgross approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit 11dcb87 into hashicorp:main Feb 15, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Feb 15, 2022
@tgross tgross added this to the 1.3.0 milestone Feb 15, 2022
@tgross tgross mentioned this pull request Feb 15, 2022
Merged
@lgfa29 lgfa29 added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line labels Apr 19, 2022
This was referenced Apr 19, 2022
Merged
Merged
This was referenced Apr 19, 2022
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees

@tgross tgross

Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

reservable_cores is not respected
4 participants
@aholyoake-bc @hashicorp-cla @tgross @lgfa29