Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: cli job run retry on "Error fetching deployment" #12062

Open
resmo opened this issue Feb 13, 2022 · 11 comments
Open

[feature]: cli job run retry on "Error fetching deployment" #12062

resmo opened this issue Feb 13, 2022 · 11 comments
Labels
help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/enhancement

Comments

@resmo
Copy link
Contributor

resmo commented Feb 13, 2022

Proposal

Add an option --retry (default 3) for monitoring the job run status.

Use-cases

We run a reverse proxy as a cetralized entry point for our devs to the nomad API. The proxy itself runs on nomad.

If our CI re-deploys that proxy accessing the API through that proxy, even with canary and rolling update it might be the cli errors out with "Error fetching deployment".

We added a retry on error in our CI, but we wished the CLI job monitoring would just retry a couple of times by itself e.g. 3 times with a delay of a second.

Attempted Solutions

canary and rolling update

@DerekStrickland DerekStrickland self-assigned this Feb 14, 2022
@DerekStrickland DerekStrickland added this to Needs Triage in Nomad - Community Issues Triage via automation Feb 14, 2022
@Amier3
Copy link
Contributor

Amier3 commented Feb 15, 2022

Hey @resmo

This would be a great feature to have so thanks for making this, we'll address this internally and get back to you with our thoughts 👍. Would you be willing to raise a PR for this?

@resmo
Copy link
Contributor Author

resmo commented Feb 15, 2022

Thanks @Amier3

I am afraid, I don't have much experience in golang.

@DerekStrickland DerekStrickland moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Feb 21, 2022
@DerekStrickland DerekStrickland removed their assignment Feb 21, 2022
@bubejur
Copy link

bubejur commented Sep 8, 2022

Hi all! @DerekStrickland do you have any news about that?

@bubejur
Copy link

bubejur commented Oct 3, 2022

@DerekStrickland @tgross Hi! Any news?

@tgross
Copy link
Member

tgross commented Oct 3, 2022

@bubejur we'll update issues when we're working on them. This isn't currently on our immediate roadmap.

@kaspergrubbe
Copy link

This would be helpful for us too! Thanks for suggesting this change.

@vkrebs-wktaa
Copy link

We upgraded our CI pipeline to use nomad cli 1.5.5 (from 1.4.4).
With 1.4.4 we could simply call nomad job run <jobfile>.
With 1.5.5 we always get the error "Error fetching deployment" after a couple of seconds.
I guess we have to implement a retry logic, beacuse the pipeline always fails now.

So ... this feature would be much appreciated.

@josh-m-sharpe
Copy link

Doubling down on @vkrebs-wktaa comment. I just upgraded from 1.3.x to 1.5.6 and now I see this error almost every time I nomad job run. Seems like a major regression.

@lgfa29 lgfa29 added stage/accepted Confirmed, and intend to work on. No timeline committment though. help-wanted We encourage community PRs for these issues! labels May 29, 2023
@lgfa29
Copy link
Contributor

lgfa29 commented May 29, 2023

Hi all 👋

Just noting here that, while investigating #17320, I noticed that the deployment monitor was not outputting the actual error that happened, which makes it hard to understand what problem is happening, so I've opened #17348 to improve this.

A retry mechanism would indeed be helpful, so I'm keeping this one opened.

@Lord-Y
Copy link

Lord-Y commented Jul 9, 2023

Any news about this?

@resmo
Copy link
Contributor Author

resmo commented Aug 11, 2023

As this software no longer has an osi approved license, closing...

@resmo resmo closed this as completed Aug 11, 2023
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Aug 11, 2023
@jrasell jrasell reopened this Aug 11, 2023
Nomad - Community Issues Triage automation moved this from Done to Needs Triage Aug 11, 2023
@angrycub angrycub moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/enhancement
Projects
Status: Needs Roadmapping
Development

No branches or pull requests