Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to namespaces #12138

Merged
merged 7 commits into from
Mar 7, 2022
Merged

Add metadata to namespaces #12138

merged 7 commits into from
Mar 7, 2022

Conversation

jorgemarey
Copy link
Contributor

This PR adds a metadata field to the namespace objects allowing users to attach custom data to namespaces.

Fixes #9631

@jrasell
Copy link
Member

jrasell commented Feb 28, 2022

Hi @jorgemarey and thanks for raising this PR. We will try and get an initial review done promptly to provide any feedback.

@schmichael
Copy link
Member

Thanks for the PR @jorgemarey! I updated some more docs and the CLI output.

Mind giving it one last look @jrasell?

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorgemarey and thanks again, this looks great!

I wonder if it would be possible to add or modify a namespace test to ensure the meta field is present as expected? /nomad/namespace_endpoint_test.go or /command/agent/namespace_endpoint_test.go perhaps?

If you could add a changelog entry that would be wonderful, this document details the process.

@jorgemarey
Copy link
Contributor Author

Hi @jrasell I added a meta value to the mock namespace. Is that enought? I also created the changelog file.

@jrasell
Copy link
Member

jrasell commented Mar 7, 2022

Hi @jrasell I added a meta value to the mock namespace. Is that enought? I also created the changelog file.

Yeah that is a great idea.

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jorgemarey!

Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrasell and @jorgemarey!

@schmichael schmichael merged commit 7c21709 into hashicorp:main Mar 7, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support for namespace metadata tags
3 participants