Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about artifact downloading #1219

Closed
c4milo opened this issue May 31, 2016 · 5 comments
Closed

Improve documentation about artifact downloading #1219

c4milo opened this issue May 31, 2016 · 5 comments
Assignees
Labels
theme/docs Documentation issues and enhancements

Comments

@c4milo
Copy link
Contributor

c4milo commented May 31, 2016

For instance, one very subtle detail that almost always bites me is that
instead of specifying the source mybucket.s3.amazonaws.com/containers/vault.tar.gz I always do it with the protocol scheme like so: https://mybucket.s3.amazonaws.com/containers/vault.tar.gz and nomad fails downloading the artifact from S3 with 403.

@pshima
Copy link
Contributor

pshima commented Jun 3, 2016

Closing with #1232

@pshima pshima closed this as completed Jun 3, 2016
@c4milo
Copy link
Contributor Author

c4milo commented Jun 3, 2016

Thank you!

@diptanu
Copy link
Contributor

diptanu commented Jun 3, 2016

@pshima Let's not close it yet, we might be able to do some validation here in the cli.

@diptanu diptanu reopened this Jun 3, 2016
@sethvargo sethvargo added the theme/docs Documentation issues and enhancements label Oct 28, 2016
@sethvargo sethvargo self-assigned this Oct 28, 2016
@sethvargo
Copy link
Contributor

Hi there,

This is done and there are now a ton of examples in both the job file and online documentation. I think it makes sense to push this kind of validation into go-getter if we want to do that validation, but it's also a relatively small win given the massive amount we've invested in documentation. I'm going to close out this issue, but it'll remain searchable for the future humans. 😄

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Development

No branches or pull requests

4 participants