CSI: snapshot list pagination parameters #12193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2022
tgross
force-pushed
the
csi-snapshot-list-pagination
branch
from
d4673a8
to
36fefeb
Compare
tgross
changed the title
tgross
force-pushed
the
csi-snapshot-list-pagination
branch
from
36fefeb
to
2377b88
Compare
The snapshot list API supports pagination as part of the CSI specification, but we didn't have it plumbed through to the command line.
tgross
force-pushed
the
csi-snapshot-list-pagination
branch
from
2377b88
to
b4c1903
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot list API supports pagination as part of the CSI
specification, but we didn't have it plumbed through to the command
line.
This also breaks E2E testing because the output from the AWS EBS plugin
can be extremely long without pagination, bringing the time it takes to
complete the command above the test timeout.
This PR requires bugfixes in #12194 #12195 and #12197, and currently includes those commits. It'll be rebased once those get merged.