CSI: fix prefix queries for plugin status
#12194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-plugin-list-filtering
branch
from
91919fc
to
4176d06
Compare
tgross
commented
Mar 4, 2022
| @@ -1100,6 +1100,7 @@ func TestCSIVolumeEndpoint_ListExternal(t *testing.T) { | |||
| // List external volumes; note that none of these exist in the state store | |||
|
|
|||
| req := &structs.CSIVolumeExternalListRequest{ | |||
| PluginID: "minnie", | |||
There was a problem hiding this comment.
Note to reviewers: these tests should have failed before and weren't because this bug masked the test bug.
The `CSIPlugin.List` RPC was intended to accept a prefix to filter the list of plugins being listed. This was being accidentally being done in the state store instead, which contributed to incorrect filtering behavior for plugins in the `volume plugin status` command. Move the prefix matching into the RPC so that it calls the prefix-matching method in the state store if we're looking for a prefix. Update the `plugin status command` to accept a prefix for the plugin ID argument so that it matches the expected behavior of other commands.
tgross
force-pushed
the
csi-plugin-list-filtering
branch
from
4176d06
to
892397e
Compare
tgross
changed the title
plugin status
lgfa29
added
backport/1.1.x
This was referenced Apr 19, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CSIPlugin.ListRPC was intended to accept a prefix to filter thelist of plugins being listed. This was being accidentally being done
in the state store instead, which contributed to incorrect filtering
behavior for plugins in the
volume plugin statuscommand.Move the prefix matching into the RPC so that it calls the
prefix-matching method in the state store if we're looking for a
prefix.
Update the
plugin status commandto accept a prefix for the pluginID argument so that it matches the expected behavior of other commands.
I pulled this out of #12193 because this will need to be backported, whereas not everything in that PR should be.