Add alloc_id to sidecar bootstrap #12543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…docs This PR expands on the work done in hashicorp#12543 to - prefix the tag, so it is now "nomad.alloc_id" to be more consistent with Consul tags - merge into pre-existing envoy_stats_tags fields - update the upgrade guide docs - update changelog
shoenig
force-pushed
the
add-allocid-to-sidecar
branch
from
1960476
to
f2ea1fa
Compare
|
Thanks @idrennanvmware, overall this looks great! In the interest of getting this in time for the 1.3 RC I went ahead and added a couple changes - namely to have the metric key be prefixed with |
shoenig
approved these changes
Apr 14, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alloc_id to envoy tags during the sidecar bootstrapping process. Addresses issue #12326
This does not change gateway bootstrapping, only sidecar bootstrapping.
Thanks to @fredwangwang and @gulavanir for the collaboration on this.