Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspicious assignment to a by-value method receiver #12592

Closed
chavacava opened this issue Apr 17, 2022 · 1 comment · Fixed by #12593
Closed

suspicious assignment to a by-value method receiver #12592

chavacava opened this issue Apr 17, 2022 · 1 comment · Fixed by #12593

Comments

@chavacava
Copy link
Contributor

The assignment to q.MaxQueryTime has no effect after exiting the method

func (q QueryOptions) SetTimeToBlock(t time.Duration) {
q.MaxQueryTime = t
}

(Found with revive)

@chavacava chavacava mentioned this issue Apr 17, 2022
@tgross tgross self-assigned this Apr 18, 2022
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Apr 18, 2022
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Apr 18, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Apr 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants