Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting explicit address on service registrations #12722

Closed
shoenig opened this issue Apr 20, 2022 · 5 comments · Fixed by #12720
Closed

Enable setting explicit address on service registrations #12722

shoenig opened this issue Apr 20, 2022 · 5 comments · Fixed by #12720
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/enhancement
Milestone

Comments

@shoenig
Copy link
Member

shoenig commented Apr 20, 2022

One feature request from #12589 is for being able to advertise arbitrary addresses in Nomad services. We can probably do the same for Consul services as well, it's much of the same plumbing.

@jorgemarey
Copy link
Contributor

jorgemarey commented May 11, 2022

Hi, just to follow on this. Would make sense to allow also setting tagged addresses on services?

Example:

    service {
      name = "gateway-mesh"
      port = "mesh_wan"

      check {
        name = "gateway-mesh-check-tcp"
        type = "tcp"
        interval = "1m"
        timeout = "15s"
      }

      tagged_addresses {
        wan = "${attr.unique.platform.aws.public-ipv4}:${NOMAD_PORT_mesh_wan}"
      }

      connect {
        gateway {
          mesh {}
          proxy {}
        }
      }
    }

@shoenig
Copy link
Member Author

shoenig commented May 11, 2022

I like that idea, @jorgemarey. Do you mind creating a fresh issue so we can track it?

@jorgemarey
Copy link
Contributor

Yes, of course. Will also try to make the PR

@jorgemarey
Copy link
Contributor

Created in #12950

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants