Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Clean up namespace query parameters #12764

Closed
7 tasks done
ChaiWithJai opened this issue Apr 22, 2022 · 2 comments · Fixed by #14117
Closed
7 tasks done

UI: Clean up namespace query parameters #12764

ChaiWithJai opened this issue Apr 22, 2022 · 2 comments · Fixed by #14117
Assignees
@ChaiWithJai
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cleanup theme/ui type/enhancement

Comments

@ChaiWithJai
Copy link
Contributor

ChaiWithJai commented Apr 22, 2022 •
edited

Namespaces used to be a query parameter, but now we serialize them with our job names.

We want to clean up everywhere where namespaces are still a query parameter:

  • topology.hbs
  • allocation-row.hbs
  • plugin-allocation-row.hbs
  • parameterized-child.hbs
  • periodic-child.hbs
  • jobs/index.hbs
  • recent-allocations.hbs
@ChaiWithJai ChaiWithJai mentioned this issue Apr 26, 2022
Merged
@lgfa29 lgfa29 added type/enhancement theme/cleanup theme/ui stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Apr 27, 2022
@philrenaud
Copy link
Contributor

Removed these from jobs/job/definition.js and jobs/run.js as part of #13588

@ChaiWithJai ChaiWithJai self-assigned this Aug 15, 2022
@ChaiWithJai ChaiWithJai mentioned this issue Aug 15, 2022
Merged
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChaiWithJai ChaiWithJai

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cleanup theme/ui type/enhancement
Projects
Nomad UI
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unnecessary query parameters in LinkTo components hashicorp/nomad
3 participants
@philrenaud @lgfa29 @ChaiWithJai