-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guest_agent
config option for QEMU driver
#12800
Conversation
…reate the socket file for the QEMU Guest Agent in the task dir when enabled
I will likely have 4-5 PRs specific to the QEMU driver to submit in the next couple weeks. Any preferences for how these are organized or any other guidance around this? @tgross maybe? Thanks! |
If you're doing a larger body of work, we'd strongly recommend opening an issue to discuss the set of changes you want to make rather than showing up with a PR for each one. That'll help us have a holistic discussion with you about the the impact of the changes. |
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Just had a look through the open issues mentioning QEMU, and it looks like much of what I want to address has been reported already.. I'll see about pulling the relevant stuff together in one issue. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll kick off the docs preview build and wait for CI to be green, and then we'll get this merged. Thanks @phreakocious!
Add boolean 'guest_agent' config option for QEMU driver, which will create the socket file for the QEMU Guest Agent in the task dir when enabled.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
When enabled, this will add the necessary virtual hardware and create a
qemu-guest-agent.sock
file in the task's working directory for interacting with the agent, which must be running in the VM to work.https://wiki.qemu.org/Features/GuestAgent