Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guest_agent config option for QEMU driver #12800

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

phreakocious
Copy link
Contributor

When enabled, this will add the necessary virtual hardware and create a qemu-guest-agent.sock file in the task's working directory for interacting with the agent, which must be running in the VM to work.
https://wiki.qemu.org/Features/GuestAgent

@phreakocious
Copy link
Contributor Author

I will likely have 4-5 PRs specific to the QEMU driver to submit in the next couple weeks. Any preferences for how these are organized or any other guidance around this? @tgross maybe? Thanks!

@tgross
Copy link
Member

tgross commented Apr 28, 2022

I will likely have 4-5 PRs specific to the QEMU driver to submit in the next couple weeks. Any preferences for how these are organized or any other guidance around this?

If you're doing a larger body of work, we'd strongly recommend opening an issue to discuss the set of changes you want to make rather than showing up with a PR for each one. That'll help us have a holistic discussion with you about the the impact of the changes.

@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Apr 28, 2022
drivers/qemu/driver.go Outdated Show resolved Hide resolved
drivers/qemu/driver.go Show resolved Hide resolved
website/content/docs/drivers/qemu.mdx Outdated Show resolved Hide resolved
Co-authored-by: Tim Gross <tgross@hashicorp.com>
@phreakocious
Copy link
Contributor Author

I will likely have 4-5 PRs specific to the QEMU driver to submit in the next couple weeks. Any preferences for how these are organized or any other guidance around this?

If you're doing a larger body of work, we'd strongly recommend opening an issue to discuss the set of changes you want to make rather than showing up with a PR for each one. That'll help us have a holistic discussion with you about the the impact of the changes.

Just had a look through the open issues mentioning QEMU, and it looks like much of what I want to address has been reported already.. I'll see about pulling the relevant stuff together in one issue. Thanks!

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll kick off the docs preview build and wait for CI to be green, and then we'll get this merged. Thanks @phreakocious!

@tgross tgross merged commit f877436 into hashicorp:main Jun 9, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Jun 9, 2022
@tgross tgross added the backport/1.3.x backport to 1.3.x release line label Jun 9, 2022
@tgross tgross added this to the 1.3.2 milestone Jun 9, 2022
tbehling pushed a commit that referenced this pull request Jun 29, 2022
Add boolean 'guest_agent' config option for QEMU driver, which will
create the socket file for the QEMU Guest Agent in the task dir when
enabled.
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line theme/driver/qemu
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants