Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting tagged addresses on services #12951

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Allow setting tagged addresses on services #12951

merged 3 commits into from
Jun 1, 2022

Conversation

jorgemarey
Copy link
Contributor

Fixes #12950

@shoenig shoenig added this to the 1.4.0 milestone May 31, 2022
@shoenig shoenig requested review from shoenig and jrasell May 31, 2022 19:15
jrasell
jrasell approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested locally!

Small inline comment within the equals addition around avoiding reflection, but it's not a blocker.

nomad/structs/services.go Outdated
@@ -825,6 +834,10 @@ OUTER:
return false
}

if !reflect.DeepEqual(s.TaggedAddresses, o.TaggedAddresses) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use helper.CompareMapStringString here rather than reflect to avoid the need for type assertion?

@shoenig shoenig merged commit 9d03cd4 into hashicorp:main Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Allow setting tagged addresses to services
3 participants
@jorgemarey @jrasell @shoenig