Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Warn if bootstrap_expect is even number #12961

Merged
merged 1 commit into from
Jun 6, 2022
Merged

feat: Warn if bootstrap_expect is even number #12961

merged 1 commit into from
Jun 6, 2022

Conversation

mr-karan
Copy link
Contributor

Closes #12957

@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation May 12, 2022
jrasell
jrasell approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mr-karan and thanks for this PR; LGTM!

@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Jun 6, 2022
@tgross
Copy link
Member

tgross commented Jun 6, 2022

@jrasell should we add this to the Nomad 1.3.2 milestone and merge it?

@jrasell jrasell added this to the 1.3.2 milestone Jun 6, 2022
@jrasell jrasell merged commit 2d95f06 into hashicorp:main Jun 6, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Jun 6, 2022
@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label Jun 9, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 9, 2022
Merged
lgfa29 added a commit that referenced this pull request Jun 9, 2022
@lgfa29
changelog: add entry for #12961
cdaed05
lgfa29 added a commit that referenced this pull request Jun 10, 2022
@lgfa29
changelog: add entry for #12961 (#13318)
f0db5f4
tbehling pushed a commit that referenced this pull request Jun 29, 2022
@lgfa29 @tbehling
changelog: add entry for #12961 (#13318)
f334c9c
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees
No one assigned
Labels
backport/1.3.x backport to 1.3.x release line
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

Warn user if bootstrap_exepect is set to an even number
4 participants
@mr-karan @tgross @jrasell @lgfa29