Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow change default endpoint for server join in case of aws #13014

Closed
obeyler opened this issue May 13, 2022 · 3 comments · Fixed by #13491
Closed

Allow change default endpoint for server join in case of aws #13014

obeyler opened this issue May 13, 2022 · 3 comments · Fixed by #13491

Comments

@obeyler
Copy link

obeyler commented May 13, 2022

Proposal

Nomad allows to join cluster by using tag on aws vm instance. (https://www.nomadproject.io/docs/configuration/server_join) In case of AWS cloud provider, unfortunately the default endpoint can not be set.

Use-cases

Sometime default aws endpoint have to be change (example in case of outscale cloud provider who share same api with aws but differs from endpoint: https://docs.outscale.com/en/userguide/Regions-Endpoints-and-Availability-Zones-Reference.html)

Attempted Solutions

I make a PR hashicorp/go-discover#194 on go-discover who give this opportunity.
If you can validate this PR and update to the new go-discover inside nomad...

@obeyler obeyler changed the title Allow chand default endpoint for server join in case of aws Allow change default endpoint for server join in case of aws May 13, 2022
@DerekStrickland DerekStrickland added this to Needs Triage in Nomad - Community Issues Triage via automation May 13, 2022
@DerekStrickland DerekStrickland moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage May 13, 2022
@Amier3
Copy link
Contributor

Amier3 commented May 24, 2022

Hey @obeyler

Thanks for making this and the associated PR . We'll keep the discussions for this on the PR

@obeyler
Copy link
Author

obeyler commented Jun 27, 2022

The associated PR is merged

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants