Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn destructive update only when count > 1 #13103

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Conversation

yaroot
Copy link
Contributor

@yaroot yaroot commented May 24, 2022

The warning doesn't make sense when count is 0 or 1 (destructive anyway). It's distractive and may cause users to ignore useful warnings.

@Amier3
Copy link
Contributor

Amier3 commented May 25, 2022

Hey @yaroot

Thanks for raising this PR. We'd prefer if PRs like this had an associated issue with it so we can discuss approach & UX, but we'll get this reviewed shortly and let you know our thoughts 😄 .

@Amier3 Amier3 added this to Needs Triage in Nomad - Community Issues Triage via automation May 25, 2022
@yaroot
Copy link
Contributor Author

yaroot commented May 25, 2022

@Amier3 I've opened #13116 for this

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yaroot!

Would you mind adding some test cases to TestJob_Warnings to check this condition?

And also add a CHANGELOG entry for this change.

@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Jun 6, 2022
@yaroot
Copy link
Contributor Author

yaroot commented Sep 1, 2022

@lgfa29 can you take a look

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 😄

@lgfa29 lgfa29 added backport/1.3.x backport to 1.3.x release line and removed stage/waiting-reply labels Sep 2, 2022
@lgfa29 lgfa29 merged commit d33f1ea into hashicorp:main Sep 2, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants