Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul/connect: enable setting consul namespace for upstream #13121

Closed
shoenig opened this issue May 25, 2022 · 4 comments
Closed

consul/connect: enable setting consul namespace for upstream #13121

shoenig opened this issue May 25, 2022 · 4 comments
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/bug

Comments

@shoenig
Copy link
Member

shoenig commented May 25, 2022

In #10235 we added the ability (in nomad-enterprise) to register Consul services via Nomad into non-default Consul namespaces.

What we didn't do is add the ability to specify to which Consul namespace a Connect service should point at via a Connect upstream.
https://www.nomadproject.io/docs/job-specification/upstreams

Consul upstream docs:
https://www.consul.io/docs/connect/registration/service-registration#upstream-configuration-reference

@shoenig shoenig added type/bug theme/consul/connect Consul Connect integration stage/accepted Confirmed, and intend to work on. No timeline committment though. labels May 25, 2022
@shoenig shoenig added this to the 1.3.x milestone May 25, 2022
@shoenig shoenig self-assigned this May 25, 2022
@luckymike
Copy link

Can this issue be expanded to support the full set of config options that Consul Connect exposes, e.g. destination_type?

@shoenig
Copy link
Member Author

shoenig commented May 26, 2022

Hi @luckymike, I created #13138 for destination_type which I can knock out for 1.3.x, and #13139 for supporting admin partitions overall, which is a substantial amount of work that we need to road map.

@MVJosh
Copy link

MVJosh commented Jul 6, 2022

Any reason why this was closed? We'd be very interested in seeing this feature implemented

@tgross
Copy link
Member

tgross commented Jul 6, 2022

@MVJosh as noted by my colleague above, it was split into #13138 and #13139. Please follow those issues if you have interest in the feature.

@hashicorp hashicorp locked and limited conversation to collaborators Jul 6, 2022
@lgfa29 lgfa29 removed this from the 1.3.x milestone Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/bug
Projects
None yet
Development

No branches or pull requests

5 participants