Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluations UI Permissions Issue with Namespaces #13142

Closed
louievandyke opened this issue May 26, 2022 · 2 comments · Fixed by #13530
Closed

Evaluations UI Permissions Issue with Namespaces #13142

louievandyke opened this issue May 26, 2022 · 2 comments · Fixed by #13530
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/bug

Comments

@louievandyke
Copy link
Contributor

Nomad version

Output from nomad version

verified on version 1.3.0-rc1 and version 1.2.6

Operating system and Environment details

18.04.1-Ubuntu

Issue

The evaluations link in the UI does not allow users to access the page, even though the token has write permissions to the namespace per the policy.

Reproduction steps

Adding a policy like below results in permissions errors when accessing the evaluations link in the UI while in the specified namespace. (Please see attachment for the image error from the UI)

lvandyke_hashicorp_com@hashistack-server-1:~$ nomad acl policy info foobar
Name        = foobar
Description = foo, bar namespace test access
Rules       = agent {
policy = "read"
}

node {
policy = "read"
}

operator {
policy = "read"
}

namespace "foo" {
policy = "write"
}

namespace "bar" {
policy = "write"
}

Expected Result

Since the policy allows write access to the namespace the expectation is that a user would be able to view the related evaluations within the UI.

Actual Result

Permissions error. Please see attachment.

I opened up developer tools in Chrome and do notice that when I'm in the namespace "bar", that when I click on the evaluations link the payload sent includes a namespace=* - I suspect that the wildcard is causing the permissions issue.

Job file (if appropriate)

eval403 (1)

Nomad Server logs (if appropriate)

Nomad Client logs (if appropriate)

@jrasell jrasell added theme/ui stage/accepted Confirmed, and intend to work on. No timeline committment though. labels May 30, 2022
@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation May 30, 2022
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage May 30, 2022
@philrenaud philrenaud moved this from Needs Roadmapping to Needs Triage in Nomad - Community Issues Triage Jun 8, 2022
@tgross tgross moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jun 10, 2022
@tgross tgross moved this from Needs Roadmapping to Needs Triage in Nomad - Community Issues Triage Jun 10, 2022
@tgross tgross moved this from Needs Triage to Triaging in Nomad - Community Issues Triage Jun 10, 2022
@philrenaud philrenaud linked a pull request Jun 29, 2022 that will close this issue
4 tasks
@tgross tgross moved this from Triaging to In Progress in Nomad - Community Issues Triage Jul 5, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Jul 11, 2022
@philrenaud
Copy link
Contributor

Hi @louievandyke — the changes from #13530 should resolve this issue. Evaluations will now load in the UI for any token, and provide as many as the token's namespace rules allow.

Thanks so much for raising the issue!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants