core: allow deleting of evaluations #13492
Conversation
| require.Nil(t, obj) | ||
| }) | ||
| }, | ||
| name: "too few eval IDs", |
There was a problem hiding this comment.
i find it's easier to grok test cases when the name is the first field
There was a problem hiding this comment.
Noted. I think I do it this way because of the process in which I build the tests which starts with what the inputs are. I have no doubt this is done in many places where I have written tests, so something I can look into changing moving forward.
| return nil | ||
| } | ||
|
|
||
| // evalDeleteSafe ensures an evaluation is safe to delete based on its related |
There was a problem hiding this comment.
Would be helpful to have this behavior described in the docs
There was a problem hiding this comment.
Yes but I want to do that for both eval reap (GC) and eval delete (operator) so will tackle this separately.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds the ability to delete evals and adds to the work performed to allow the pausing of the eval and blocked eval brokers.
There is a change made to the signature of the eval reap RPC which we will want to backport in order to make future backport releases easier. Once this PR has been reviewed and approved, I will open this change as a PR separately.
related #11638