api: apply new ACL check for wildcard namespace #13608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
commented
Jul 6, 2022
Comment on lines
1285
to
+1289
| Label: "all namespaces with insufficient token", | ||
| Namespace: "*", | ||
| Allocs: []*structs.Allocation{}, | ||
| Token: ns1tokenInsufficient.SecretID, | ||
| Error: true, | ||
| Message: structs.ErrPermissionDenied.Error(), |
There was a problem hiding this comment.
This was the only test the failed after the refactoring, but I think returning a 403 is the correct result in this case since the test token doesn't have the read-job capability?
Looking through the documentation I couldn't find any expected output.
shoenig
approved these changes
Jul 6, 2022
This was referenced Jul 6, 2022
In #13606 the ACL check was refactored to better support the all namespaces wildcard (`*`). This commit applies the changes to the jobs and alloc list endpoints.
lgfa29
force-pushed
the
refactor-wildcard-ns-acl-check-job-alloc
branch
from
54f3d21
to
98d8fee
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13606 the ACL check was refactored to better support the all
namespaces wildcard (
*). This commit applies the changes to the jobsand alloc list endpoints.