servicedisco: unable to register services of the same name but different tags in the same group

[shoenig]

I suspect we might be storing services of a group in a map[service.name] somewhere, when that isn't enough to ensure uniqueness (i.e. instead use service.Hash()).

E.g.

job "simple" {
  datacenters = ["dc1"]
  type        = "service"

  group "database" {

    service {
      name     = "db"
      tags     = ["one"]
      provider = "nomad"
    }

    service {
      name     = "db"
      tags     = ["two"]
      provider = "nomad"
    }

    task "db" {
      driver = "raw_exec"
      config {
        command = "bash"
        args    = ["-c", "sleep 15000"]
      }
    }
  }
}

only one instance of the service shows up

$ nomad service info db
Job ID     Address  Tags   Node ID   Alloc ID
simple_lb  <none>   [two]  1a9a9fe9  37058c6a

and

$ nomad service list
Service Name  Tags
db            [two]

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.