Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nomad RetryConfig to agent template config #13907

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

DerekStrickland
Copy link
Contributor

@DerekStrickland DerekStrickland commented Jul 23, 2022

Closes #13019

This PR introduces a retry configuration option for Nomad dependencies in Consul Template. For example, Nomad native service discovery and secure variables will make calls to the Nomad API. If connectivity is lost between the client and the servers, these calls will fail and the task may fail or run with stale data forever depending on the type of error. Operators can now specify a nomad_retry stanza in the same way they can for Vault or Consul. The default config attempts is set to 0 which allows for infinite retries.

@DerekStrickland DerekStrickland changed the title [WIP]: Add Nomad RetryConfig to agent template config Add Nomad RetryConfig to agent template config Aug 3, 2022
@DerekStrickland DerekStrickland self-assigned this Aug 3, 2022
@DerekStrickland DerekStrickland added this to the 1.3.3 milestone Aug 3, 2022
@DerekStrickland DerekStrickland marked this pull request as ready for review August 3, 2022 19:50
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line theme/consul-template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option to avoid task failure on template failure
2 participants